Feature/admin forth/1259/add delete many to dataapi#502
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a deleteMany method to AdminForth's data API layer, enabling bulk deletion of records by primary key across all supported database connectors (SQLite, PostgreSQL, MySQL, MongoDB, ClickHouse).
Changes:
- Added
deleteManymethod to all five data connectors (SQLite, PostgreSQL, MySQL, MongoDB, ClickHouse) and to the type interfaces (IAdminForthDataSourceConnectorBase,IOperationalResource). - Added a new
adminforth-auto-removeplugin reference in the dev-demo Taskfile.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| adminforth/types/Back.ts | Adds deleteMany to connector and operational resource interfaces |
| adminforth/dataConnectors/sqlite.ts | Implements deleteMany using parameterized ? placeholders |
| adminforth/dataConnectors/postgres.ts | Implements deleteMany using $N placeholders |
| adminforth/dataConnectors/mysql.ts | Implements deleteMany using ? placeholders |
| adminforth/dataConnectors/mongo.ts | Implements deleteMany using $in operator |
| adminforth/dataConnectors/clickhouse.ts | Implements deleteMany with string-interpolated IDs |
| dev-demo/Taskfile.yaml | Adds adminforth-auto-remove to the plugins list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
This PR adds a deleteMany method to the data API layer, enabling bulk deletion of records by primary key across all five database connectors (SQLite, PostgreSQL, MySQL, MongoDB, ClickHouse). It also registers a new adminforth-auto-remove plugin in the dev-demo task configuration.
Changes:
- Added
deleteManyimplementations to all five data connectors (sqlite, postgres, mysql, mongo, clickhouse) for batch deletion by record IDs. - Declared
deleteManyas an optional method on theIOperationalResourceinterface inBack.ts. - Added
adminforth-auto-removeto the dev-demo plugin list.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| adminforth/types/Back.ts | Added optional deleteMany to IOperationalResource interface |
| adminforth/dataConnectors/sqlite.ts | New deleteMany using parameterized IN (?) query |
| adminforth/dataConnectors/postgres.ts | New deleteMany using parameterized IN ($1, $2, ...) query |
| adminforth/dataConnectors/mysql.ts | New deleteMany using parameterized IN (?) query |
| adminforth/dataConnectors/mongo.ts | New deleteMany using $in operator |
| adminforth/dataConnectors/clickhouse.ts | New deleteMany using ALTER TABLE ... DELETE WHERE with named params |
| dev-demo/Taskfile.yaml | Added adminforth-auto-remove to plugins list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| deleteMany?(recordIds: any[]): Promise<number>; |
|
|
||
| deleteMany?(recordIds: any[]): Promise<number>; |
No description provided.